Revert constification of Borrow and Deref for Cow due to inference failure
#148016
Conversation
rustbot
added
S-waiting-on-review
|
rustbot has assigned @Mark-Simulacrum. Use |
|
@rustbot blocked |
rustbot
added
S-blocked
theemathas
added
the
beta-nominated
|
@rustbot ready |
rustbot
added
S-waiting-on-review
clarfonthey
force-pushed
the
const-convert-revert-2
branch
from
72c9876 to
ebd5bea
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
How about adding the minimized regression test? |
|
Right, I wasn't sure what the timing was for the beta backport but I can add one later today. |
|
Added a simple regression test which seems to both pass with this fix, and fail without it. No idea if this is best as a UI test in its current location or not, so, feel free to suggest changes if you have opinions about it. Also made a separate commit in case the backport timing means we want to merge without the test bikeshedding sooner. Also to clarify, when I meant that a crater run is necessary, I mean that there might have been other inference issues caused by trait constification that didn't surface due to the existence of these issues, so, it's worth double-checking after everything is merged. Not sure if this specific issue is fully resolved after this PR or not. |
bors
added
S-waiting-on-bors
rustbot
added
the
beta-accepted
…, r=cuviper Revert constification of `Borrow` and `Deref for Cow` due to inference failure Reported issue: rust-lang#147964 Original PR: rust-lang#145279 Previous revert: rust-lang#148011 `const Borrow`/`Deref` tracking issue: rust-lang#143773 Should have additional crater run to verify this fixes the issue. Since other PR is in the queue, this will need to be rebased after that merges. Also will want a beta nomination.
Rollup of 5 pull requests Successful merges: - #148016 (Revert constification of `Borrow` and `Deref for Cow` due to inference failure) - #148021 ([rustdoc] Simplify module rendering and HTML tags handling) - #148039 (Add myself to the review rotation) - #148042 (test(frontmatter): Cover spaces between infostring parts) - #148054 (Streamline iterator chaining when computing successors.) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #148016 - clarfonthey:const-convert-revert-2, r=cuviper Revert constification of `Borrow` and `Deref for Cow` due to inference failure Reported issue: #147964 Original PR: #145279 Previous revert: #148011 `const Borrow`/`Deref` tracking issue: #143773 Should have additional crater run to verify this fixes the issue. Since other PR is in the queue, this will need to be rebased after that merges. Also will want a beta nomination.
|
Bors hasn't noticed that this was merged. @bors r- |
bors
added
S-waiting-on-author
cuviper
removed
the
beta-nominated
[beta] backports - Revert constification of `AsRef for Cow` due to inference failure #148011 - Revert constification of `Borrow` and `Deref for Cow` due to inference failure #148016 - Revert "fix: Filter suggestion parts that match existing code" #148043 - Revert "feat: implement `hash_map!` macro" #148049 - fix panic when rustc tries to reduce intermediate filenames len with utf8 #148018 r? cuviper
[beta] backports - Revert constification of `AsRef for Cow` due to inference failure #148011 - Revert constification of `Borrow` and `Deref for Cow` due to inference failure #148016 - Revert "fix: Filter suggestion parts that match existing code" #148043 - Revert "feat: implement `hash_map!` macro" #148049 - fix panic when rustc tries to reduce intermediate filenames len with utf8 #148018 r? cuviper
7 participants
Reported issue: #147964
Original PR: #145279
Previous revert: #148011
const Borrow/Dereftracking issue: #143773Should have additional crater run to verify this fixes the issue.
Since other PR is in the queue, this will need to be rebased after that merges. Also will want a beta nomination.